pom.xml (1)

54-58: Consider adding <scope>runtime</scope> for consistency.

The slf4j-nop dependency is a no-op logging binding typically only needed at runtime to suppress SLF4J warning messages. Adding <scope>runtime</scope> would align with the intent and match the pattern used by mysql-connector-j above.

         <dependency>
             <groupId>org.slf4j</groupId>
             <artifactId>slf4j-nop</artifactId>
             <version>2.0.17</version>
+            <scope>runtime</scope>
         </dependency>

src/main/java/com/example/Main.java (4)

133-133: Stale TODO comment.

This TODO comment appears to be leftover from a template. Since the run() method is now fully implemented, consider removing it to avoid confusion.

-        //Todo: Starting point for your code

---

169-189: Consider validating user_id input.

If user_id is a numeric column, using setString relies on implicit type conversion. Consider parsing to int/long and using setInt/setLong for type safety, similar to the approach in moonMissionsById.

---

216-219: Inconsistent error handling pattern.

This method prints to System.err before throwing RuntimeException, while other methods (e.g., deleteAccount, createAnAccount) throw directly. Consider removing the System.err.println for consistency.

         } catch (SQLException e) {
-            System.err.println("ERROR: Failed to update password.");
             throw new RuntimeException("Database operation failed. " + e.getMessage());
         }

---

281-297: Redundant input validation logic.

The method checks hasNextInt() on line 283, but then reads as nextLine() and re-parses as Long with a try-catch on lines 291-297. The hasNextInt() check is effectively bypassed by reading the whole line. Consider simplifying:

     private void moonMissionsById(Connection connection, Scanner scanner) {
         System.out.println("Enter moon mission id: ");
-        if (!scanner.hasNextInt()) {
+        if (!scanner.hasNextLine()) {
             return;
         }
         String missionId = scanner.nextLine().trim();
+        
+        long id;
+        try {
+            id = Long.parseLong(missionId);
+        } catch (NumberFormatException e) {
+            System.out.println("Invalid moon mission id. Please enter a number");
+            return;
+        }

         String sql = "select spacecraft, mission_id, mission_type, launch_date from moon_mission where mission_id = ?";
         try (PreparedStatement stmt = connection.prepareStatement(sql)) {
-            long id;
-            try {
-                id = Long.parseLong(missionId);
-                stmt.setLong(1, id);
-            } catch (NumberFormatException e) {
-                System.out.println("Invalid moon mission id. Please enter a number");
-                return;
-            }
+            stmt.setLong(1, id);

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

src/main/java/com/example/Main.java (1)

245-278: Account creation: fix wrong validation message + add missing EOF guards (and avoid crashing the CLI)

• Line 254 throws “First name…” when validating last name.
• Lines 256–258 read without hasNextLine() (EOF can throw), and IllegalArgumentException will currently crash the interactive flow (better to print + return).

-        if (lastName.length() < 3) { throw new IllegalArgumentException("First name must be at least 3 characters long."); }
+        if (lastName.length() < 3) {
+            System.out.println("Last name must be at least 3 characters long.");
+            return;
+        }
         System.out.print("Enter ssn: ");
+        if (!scanner.hasNextLine()) { return; }
         String ssn = scanner.nextLine().trim();
         System.out.print("Enter password: ");
+        if (!scanner.hasNextLine()) { return; }
         String password = scanner.nextLine().trim();

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

src/main/java/com/example/Main.java (5)

291-328: Good userId validation, but trim the password input and preserve exception cause.

The userId validation (lines 296-303) properly addresses the previous review comment. However, line 309 should trim the password input for consistency, and line 326 should include the SQLException cause.

Apply this diff:

         System.out.println("Enter new password: ");
         if (!scanner.hasNextLine()) {
             return;
         }
-        String newPassword = scanner.nextLine();
+        String newPassword = scanner.nextLine().trim();
 
         String sql = " update account set password = ? where user_id = ? ";
         try (PreparedStatement stmt = connection.prepareStatement(sql)) {
             stmt.setString(1, newPassword);
             stmt.setLong(2, userId);
 
             int affectedRows = stmt.executeUpdate();
 
             if (affectedRows > 0) {
                 System.out.println("Account updated successfully.");
             } else {
                 System.out.println("Failed to update account.");
             }
 
         } catch (SQLException e) {
             System.err.println("ERROR: Failed to update password.");
-            throw new RuntimeException("Database operation failed. " + e.getMessage());
+            throw new RuntimeException("Database operation failed. " + e.getMessage(), e);
         }

---

135-164: Plaintext password authentication remains unresolved.

The authentication method still compares passwords in plaintext (line 148). This is a significant security risk even for a CLI application. Additionally, line 162 throws a RuntimeException without any descriptive context, making debugging difficult.

Please implement password hashing (bcrypt or Argon2) and improve exception context:

-        String sql = " select name from account where name = ? and password = ? ";
+        String sql = " select name, password from account where name = ? ";
 
         try (PreparedStatement stmt = connection.prepareStatement(sql)) {
             stmt.setString(1, username);
-            stmt.setString(2, password);
 
             try (ResultSet rs = stmt.executeQuery()) {
                 if (rs.next()) {
-                    return rs.getString("name");
+                    String storedHash = rs.getString("password");
+                    // Verify password against stored hash using BCrypt or similar
+                    if (verifyPassword(password, storedHash)) {
+                        return rs.getString("name");
+                    }
+                    return null;
                 } else {
                     return null;
                 }
             }
         } catch (SQLException ex) {
-            throw new RuntimeException(ex);
+            throw new RuntimeException("Failed to authenticate user: " + username, ex);
         }

Note: Based on learnings or past feedback, if plaintext is acceptable for this educational/demo context, at minimum fix the exception message.

---

185-217: Misleading error message and missing exception context.

Line 210 says "Please enter a number" even though the input was successfully parsed as a number—it just wasn't found in the database. Line 215 throws a generic RuntimeException without context.

Apply this diff:

                 } else {
-                    System.out.println("Mission id " + missionId + " not found. Please enter a number");
+                    System.out.println("Mission id " + missionId + " not found.");
                 }
             }
 
         } catch (SQLException e) {
-            throw new RuntimeException(e);
+            throw new RuntimeException("Error fetching moon mission by id=" + id, e);
         }

---

252-289: Good length validation, but passwords stored in plaintext and exception cause missing.

The length validation (lines 257-263) properly addresses the previous StringIndexOutOfBoundsException risk. However, line 277 stores the password in plaintext in the database, and line 287 doesn't preserve the SQLException cause.

Apply this diff:

         System.out.print("Enter password: ");
         if (!scanner.hasNextLine()) {return;}
         String password = scanner.nextLine().trim();
+        // Hash the password before storage (use BCrypt, Argon2, etc.)
+        String hashedPassword = hashPassword(password);
         String name = firstName.substring(0, 3) + lastName.substring(0, 3);
 
         String sql = "INSERT INTO account (first_name, last_name, ssn, password, name) VALUES (?, ?, ?, ?, ?)";
         try (PreparedStatement stmt = connection.prepareStatement(sql)) {
             stmt.setString(1, firstName);
             stmt.setString(2, lastName);
             stmt.setString(3, ssn);
-            stmt.setString(4, password);
+            stmt.setString(4, hashedPassword);
             stmt.setString(5, name);
 
             int affectedRows = stmt.executeUpdate();
             if (affectedRows > 0) {
                 System.out.println("Successfully created an account for " + firstName + " " + lastName);
             } else
                 System.out.println("Failed to create an account.");
 
         } catch (SQLException e) {
-            throw new RuntimeException("Database operation failed. " + e.getMessage());
+            throw new RuntimeException("Database operation failed. " + e.getMessage(), e);
         }

Note: If plaintext is acceptable for this educational context, at minimum fix the exception cause.

---

330-350: Validate and trim userId input, and preserve exception cause.

The method should validate that userId is numeric (similar to updateAccountPassword) and trim the input. Line 348 should also include the SQLException cause for better debugging.

Apply this diff:

         System.out.println("Enter user id, that you wish to delete: ");
         if (!scanner.hasNextLine()) {
             return;
         }
-        String userId = scanner.nextLine();
+        String userIdStr = scanner.nextLine().trim();
+        long userId;
+        try {
+            userId = Long.parseLong(userIdStr);
+        } catch (NumberFormatException e) {
+            System.out.println("Invalid user_id. Please enter a number.");
+            return;
+        }
 
         String sql = " delete from account where user_id = ? ";
         try (PreparedStatement stmt = connection.prepareStatement(sql)) {
-            stmt.setString(1, userId);
+            stmt.setLong(1, userId);
 
             int affectedRows = stmt.executeUpdate();
             if (affectedRows > 0) {
                 System.out.println("Successfully deleted the account.");
             } else {
                 System.out.println("Failed to delete the account.");
             }
         } catch (SQLException e) {
-            throw new RuntimeException("Database operation failed. " + e.getMessage());
+            throw new RuntimeException("Database operation failed. " + e.getMessage(), e);
         }

src/main/java/com/example/Main.java (1)

219-250: Good input validation, but add exception context.

The NumberFormatException handling (lines 227-232) properly addresses the previous review comment. However, line 248 should include a descriptive message in the RuntimeException.

Apply this diff to improve exception context:

         } catch (SQLException e) {
-            throw new RuntimeException(e);
+            throw new RuntimeException("Error counting missions for year=" + year, e);
         }

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro